CHANGELOG revision 355db7c6
12018-05-16 2 3 - [BUGFIX] Frame insertion mis-ID as overlap instead of dup 4 - http_client: fix priority range generated by -E flag 5 62018-05-09 7 8 - [FEATURE] Add support for Q043. 9 - Support for versions Q037, Q038, Q041, and Q042 has been removed. 10 - Fix typo in debug message. 11 - Fix code indentation. 12 - Add /* fallthru */ comment to stop newer gcc from complaining. 13 - Logger: fix compilation of optimized Windows build. 14 152018-05-04 16 17 - [FEATURE] Add support for Q042. 18 - Remove comment: MSPC is obsolete (no code changes) 19 - Prog: use lsquic_str2ver() when processing -o version flag 20 - Remove unused CTIM and SRBF transport parameters 21 - Disable QUIC versions Q037 and Q038 by default 22 - Fix Windows compilation by including compat header file in 23 lshpack.c 24 - Address warnings produced by newer versions of gcc 25 - Future-proof: turn off -Werror 26 272018-05-02 28 29 - [BUGFIX] Make lsquic_conn_quic_version() available 30 - Switch to using ls-hpack 1.1 31 - [BUGFIX] Do not ignore stream resets after receiving FIN 32 332018-04-27 34 35 - HPACK: do not allow header block to end with table size update. 36 372018-04-25 38 39 - [BUGFIX] Do not create gap in sent packnos when squeezing delayed 40 packets. 41 - [BUGFIX] sendctl checks for all unacked bytes, not just retx bytes. 42 - [BUGFIX] connections with blocked scheduled packets are not tickable 43 for sending. 44 - [BUGFIX] Conn is tickable if it wants to send a connection-level 45 frame. 46 472018-04-23 48 49 - Fix busy loop: tickable must make progress. When connection is 50 self-reporting as tickable, it must make progress when ticked. There 51 are two issues: 52 1. If there are buffered packets, the connection is only tickable if 53 they can be sent out. 54 2. A connection is tickable if there are streams on the servicing 55 queue. When the tick occurs, we must service the stream 56 independent of whether any packets are sent. 57 - Fix assertion in pacer which can be incorrect under some 58 conditions. 59 - cmake: do not turn on address sanitizer if in Travis. 60 612018-04-20 62 63 - [BUGFIX] Fix bug in lsquic_engine_connect() exposed by yesterday's 64 changes. 65 662018-04-19 67 68 - [BUGFIX] Add connection to Tickable Queue on stream write 69 - cmake: use MSVC variable instead of trying to detect 70 - engine: improve connection incref/decref logging 71 - stream: don't ignore errors that may occur on triggered flush 72 - connection: remove obsolete method 73 - engine: indicate connection as tickable if previous call went 74 over threshold 75 762018-04-09 77 78 [API Change, OPTIMIZATION] Only process conns that need to be processed 79 80 The API is simplified: do not expose the user code to several 81 queues. A "connection queue" is now an internal concept. 82 The user processes connections using the single function 83 lsquic_engine_process_conns(). When this function is called, 84 only those connections are processed that need to be processed. 85 A connection needs to be processed when: 86 87 1. New incoming packets have been fed to the connection. 88 2. User wants to read from a stream that is readable. 89 3. User wants to write to a stream that is writeable. 90 4. There are buffered packets that can be sent out. (This 91 means that the user wrote to a stream outside of the 92 lsquic library callback.) 93 5. A control frame (such as BLOCKED) needs to be sent out. 94 6. A stream needs to be serviced or delayed stream needs to 95 be created. 96 7. An alarm rings. 97 8. Pacer timer expires. 98 99 To achieve this, the library places the connections into two 100 priority queues (min heaps): 101 102 1. Tickable Queue; and 103 2. Advisory Tick Time queue (ATTQ). 104 105 Each time lsquic_engine_process_conns() is called, the Tickable 106 Queue is emptied. After the connections have been ticked, they are 107 queried again: if a connection is not being closed, it is placed 108 either in the Tickable Queue if it is ready to be ticked again or 109 it is placed in the Advisory Tick Time Queue. It is assumed that 110 a connection always has at least one timer set (the idle alarm). 111 112 The connections in the Tickable Queue are arranged in the least 113 recently ticked order. This lets connections that have been quiet 114 longer to get their packets scheduled first. 115 116 This change means that the library no longer needs to be ticked 117 periodically. The user code can query the library when is the 118 next tick event and schedule it exactly. When connections are 119 processed, only the tickable connections are processed, not *all* 120 the connections. When there are no tick events, it means that no 121 timer event is necessary -- only the file descriptor READ event 122 is active. 123 124 The following are improvements and simplifications that have 125 been triggered: 126 127 - Queue of connections with incoming packets is gone. 128 - "Pending Read/Write Events" Queue is gone (along with its 129 history and progress checks). This queue has become the 130 Tickable Queue. 131 - The connection hash no longer needs to track the connection 132 insertion order. 133 1342018-04-02 135 136 - [FEATURE] Windows support 137 138 - Reduce stack use -- outgoing packet batch is now allocated on the heap. 139 1402018-03-09 141 142 - [OPTIMIZATION] Merge series of ACKs if possible 143 144 Parsed single-range ACK frames (that is the majority of frames) are 145 saved in the connection and their processing is deferred until the 146 connection is ticked. If several ACKs come in a series between 147 adjacent ticks, we check whether the latest ACK is a strict superset 148 of the saved ACK. If it is, the older ACK is not processed. 149 150 If ACK frames can be merged, they are merged and only one of them is 151 either processed or saved. 152 153 - [OPTIMIZATION] Speed up ACK verification by simplifying send history. 154 155 Never generate a gap in the sent packet number sequence. This reduces 156 the send history to a single number instead of potentially a series of 157 packet ranges and thereby speeds up ACK verification. 158 159 By default, detecting a gap in the send history is not fatal: only a 160 single warning is generated per connection. The connection can continue 161 to operate even if the ACK verification code is not able to detect some 162 inconsistencies. 163 164 - [OPTIMIZATION] Rearrange the lsquic_send_ctl struct 165 166 The first part of struct lsquic_send_ctl now consists of members that 167 are used in lsquic_send_ctl_got_ack() (in the absense of packet loss, 168 which is the normal case). To speed up reads and writes, we no longer 169 try to save space by using 8- and 16-bit integers. Use regular integer 170 width for everything. 171 172 - [OPTIMIZATION] Cache size of sent packet. 173 174 - [OPTIMIZATION] Keep track of the largest ACKed in packet_out 175 176 Instead of parsing our own ACK frames when packet has been acked, 177 use the value saved in the packet_out structure when the ACK frame 178 was generated. 179 180 - [OPTIMIZATION] Take RTT sampling conditional out of ACK loop 181 182 - [OPTIMIZATION] ACK processing: only call clock_gettime() if needed 183 184 - [OPTIMIZATION] Several code-level optimizations to ACK processing. 185 186 - Fix: http_client: fix -I flag; switch assert() to abort() 187 1882018-02-26 189 - [API Change] lsquic_engine_connect() returns pointer to the connection 190 object. 191 - [API Change] Add lsquic_conn_get_engine() to get engine object from 192 connection object. 193 - [API Change] Add lsquic_conn_status() to query connection status. 194 - [API Change] Add add lsquic_conn_set_ctx(). 195 - [API Change] Add new timestamp format, e.g. 2017-03-21 13:43:46.671345 196 - [OPTIMIZATION] Process handshake STREAM frames as soon as packet 197 arrives. 198 - [OPTIMIZATION] Do not compile expensive send controller sanity check 199 by default. 200 - [OPTIMIZATION] Add fast path to gquic_be_gen_reg_pkt_header. 201 - [OPTIMIZATION] Only make squeeze function call if necessary. 202 - [OPTIMIZATION] Speed up Q039 ACK frame parsing. 203 - [OPTIMIZATION] Fit most used elements of packet_out into first 64 bytes. 204 - [OPTIMIZATION] Keep track of scheduled bytes instead of calculating. 205 - [OPTIMIZATION] Prefetch next unacked packet when processing ACK. 206 - [OPTIMIZATION] Leverage fact that ACK ranges and unacked list are. 207 ordered. 208 - [OPTIMIZATION] Reduce function pointer use for STREAM frame generation 209 - Fix: reset incoming streams that arrive after we send GOAWAY. 210 - Fix: delay client on_new_conn() call until connection is fully set up. 211 - Fixes to buffered packets logic: splitting, STREAM frame elision. 212 - Fix: do not dispatch on_write callback if no packets are available. 213 - Fix WINDOW_UPDATE send and resend logic. 214 - Fix STREAM frame extension code. 215 - Fix: Drop unflushed data when stream is reset. 216 - Switch to tracking CWND using bytes rather than packets. 217 - Fix TCP friendly adjustment in cubic. 218 - Fix: do not generate invalid STOP_WAITING frames during high packet 219 loss. 220 - Pacer fixes. 221 2222017-12-18 223 224 - Fix: better follow cubic curve after idle period 225 - Fix: add missing parts to outgoing packet splitting code 226 - Fix: compilation using gcc 4.8.4 227 2282017-10-31 229 230 - Add APIs.txt -- describes LSQUIC APIs 231 2322017-10-31 233 234 - [API Change] Sendfile-like functionality is gone. The stream no 235 longer opens files and deals with file descriptors. (Among other 236 things, this makes the code more portable.) Three writing functions 237 are provided: 238 239 lsquic_stream_write 240 lsquic_stream_writev 241 lsquic_stream_writef (NEW) 242 243 lsquic_stream_writef() is given an abstract reader that has function 244 pointers for size() and read() functions which the user can implement. 245 This is the most flexible way. lsquic_stream_write() and 246 lsquic_stream_writev() are now both implemented as wrappers around 247 lsquic_stream_writef(). 248 249 - [OPTIMIZATION] When writing to stream, be it within or without the 250 on_write() callback, place data directly into packet buffer, 251 bypassing auxiliary data structures. This reduces amount of memory 252 required, for the amount of data that can be written is limited 253 by the congestion window. 254 255 To support writes outside the on_write() callback, we keep N 256 outgoing packet buffers per connection which can be written to 257 by any stream. One half of these are reserved for the highest 258 priority stream(s), the other half for all other streams. This way, 259 low-priority streams cannot write instead of high-priority streams 260 and, on the other hand, low-priority streams get a chance to send 261 their packets out. 262 263 The algorithm is as follows: 264 265 - When user writes to stream outside of the callback: 266 - If this is the highest priority stream, place it onto the 267 reserved N/2 queue or fail. 268 (The actual size of this queue is dynamic -- MAX(N/2, CWND) -- 269 rather than N/2, allowing high-priority streams to write as 270 much as can be sent.) 271 - If the stream is not the highest priority, try to place the 272 data onto the reserved N/2 queue or fail. 273 - When tick occurs *and* more packets can be scheduled: 274 - Transfer packets from the high N/2 queue to the scheduled 275 queue. 276 - If more scheduling is allowed: 277 - Call on_write callbacks for highest-priority streams, 278 placing resulting packets directly onto the scheduled queue. 279 - If more scheduling is allowed: 280 - Transfer packets from the low N/2 queue to the scheduled 281 queue. 282 - If more scheduling is allowed: 283 - Call on_write callbacks for non-highest-priority streams, 284 placing resulting packets directly onto the scheduled queue 285 286 The number N is currently 20, but it could be varied based on 287 resource usage. 288 289 - If stream is created due to incoming headers, make headers readable 290 from on_new. 291 292 - Outgoing packets are no longer marked non-writeable to prevent placing 293 more than one STREAM frame from the same stream into a single packet. 294 This property is maintained via code flow and an explicit check. 295 Packets for stream data are allocated using a special function. 296 297 - STREAM frame elision is cheaper, as we only perform it if a reset 298 stream has outgoing packets referencing it. 299 300 - lsquic_packet_out_t is smaller, as stream_rec elements are now 301 inside a union. 302 3032017-10-12 304 305 - Do not send RST_STREAM when stream is closed for reading 306 - Raise maximum header size from 4K to 64K 307 - Check header name and value lengths against maximum imposed by HPACK 308 - Fix NULL dereference in stream flow controller 309 3102017-10-09 311 312 - Hide handshake implementation behind a set of function pointers 313 - Use monotonically increasing clock 314 - Make sure that retx delay is not larger than the max of 60 seconds 315 3162017-09-29 317 318 - A few fixes to code and README 319 3202017-09-28 321 322 - Add support for Q041; drop support for Q040 323 3242017-09-27 325 326 - Fix CMakeLists.txt: BoringSSL include and lib was mixed up 327 3282017-09-26 329 330 - Add support for Mac OS 331 - Add support for Raspberry Pi 332 - Fix BoringSSL compilation: include <openssl/hmac.h> explicitly 333 3342017-09-22 335 336 - Initial release 337