CHANGELOG revision 4b332c36
12018-05-04 2 3 - Remove comment: MSPC is obsolete (no code changes) 4 - Prog: use lsquic_str2ver() when processing -o version flag 5 - Remove unused CTIM and SRBF transport parameters 6 - Disable QUIC versions Q037 and Q038 by default 7 - Fix Windows compilation by including compat header file in 8 lshpack.c 9 - Address warnings produced by newer versions of gcc 10 - Future-proof: turn off -Werror 11 122018-05-02 13 14 - [BUGFIX] Make lsquic_conn_quic_version() available 15 - Switch to using ls-hpack 1.1 16 - [BUGFIX] Do not ignore stream resets after receiving FIN 17 182018-04-27 19 20 - HPACK: do not allow header block to end with table size update. 21 222018-04-25 23 24 - [BUGFIX] Do not create gap in sent packnos when squeezing delayed 25 packets. 26 - [BUGFIX] sendctl checks for all unacked bytes, not just retx bytes. 27 - [BUGFIX] connections with blocked scheduled packets are not tickable 28 for sending. 29 - [BUGFIX] Conn is tickable if it wants to send a connection-level 30 frame. 31 322018-04-23 33 34 - Fix busy loop: tickable must make progress. When connection is 35 self-reporting as tickable, it must make progress when ticked. There 36 are two issues: 37 1. If there are buffered packets, the connection is only tickable if 38 they can be sent out. 39 2. A connection is tickable if there are streams on the servicing 40 queue. When the tick occurs, we must service the stream 41 independent of whether any packets are sent. 42 - Fix assertion in pacer which can be incorrect under some 43 conditions. 44 - cmake: do not turn on address sanitizer if in Travis. 45 462018-04-20 47 48 - [BUGFIX] Fix bug in lsquic_engine_connect() exposed by yesterday's 49 changes. 50 512018-04-19 52 53 - [BUGFIX] Add connection to Tickable Queue on stream write 54 - cmake: use MSVC variable instead of trying to detect 55 - engine: improve connection incref/decref logging 56 - stream: don't ignore errors that may occur on triggered flush 57 - connection: remove obsolete method 58 - engine: indicate connection as tickable if previous call went 59 over threshold 60 612018-04-09 62 63 [API Change, OPTIMIZATION] Only process conns that need to be processed 64 65 The API is simplified: do not expose the user code to several 66 queues. A "connection queue" is now an internal concept. 67 The user processes connections using the single function 68 lsquic_engine_process_conns(). When this function is called, 69 only those connections are processed that need to be processed. 70 A connection needs to be processed when: 71 72 1. New incoming packets have been fed to the connection. 73 2. User wants to read from a stream that is readable. 74 3. User wants to write to a stream that is writeable. 75 4. There are buffered packets that can be sent out. (This 76 means that the user wrote to a stream outside of the 77 lsquic library callback.) 78 5. A control frame (such as BLOCKED) needs to be sent out. 79 6. A stream needs to be serviced or delayed stream needs to 80 be created. 81 7. An alarm rings. 82 8. Pacer timer expires. 83 84 To achieve this, the library places the connections into two 85 priority queues (min heaps): 86 87 1. Tickable Queue; and 88 2. Advisory Tick Time queue (ATTQ). 89 90 Each time lsquic_engine_process_conns() is called, the Tickable 91 Queue is emptied. After the connections have been ticked, they are 92 queried again: if a connection is not being closed, it is placed 93 either in the Tickable Queue if it is ready to be ticked again or 94 it is placed in the Advisory Tick Time Queue. It is assumed that 95 a connection always has at least one timer set (the idle alarm). 96 97 The connections in the Tickable Queue are arranged in the least 98 recently ticked order. This lets connections that have been quiet 99 longer to get their packets scheduled first. 100 101 This change means that the library no longer needs to be ticked 102 periodically. The user code can query the library when is the 103 next tick event and schedule it exactly. When connections are 104 processed, only the tickable connections are processed, not *all* 105 the connections. When there are no tick events, it means that no 106 timer event is necessary -- only the file descriptor READ event 107 is active. 108 109 The following are improvements and simplifications that have 110 been triggered: 111 112 - Queue of connections with incoming packets is gone. 113 - "Pending Read/Write Events" Queue is gone (along with its 114 history and progress checks). This queue has become the 115 Tickable Queue. 116 - The connection hash no longer needs to track the connection 117 insertion order. 118 1192018-04-02 120 121 - [FEATURE] Windows support 122 123 - Reduce stack use -- outgoing packet batch is now allocated on the heap. 124 1252018-03-09 126 127 - [OPTIMIZATION] Merge series of ACKs if possible 128 129 Parsed single-range ACK frames (that is the majority of frames) are 130 saved in the connection and their processing is deferred until the 131 connection is ticked. If several ACKs come in a series between 132 adjacent ticks, we check whether the latest ACK is a strict superset 133 of the saved ACK. If it is, the older ACK is not processed. 134 135 If ACK frames can be merged, they are merged and only one of them is 136 either processed or saved. 137 138 - [OPTIMIZATION] Speed up ACK verification by simplifying send history. 139 140 Never generate a gap in the sent packet number sequence. This reduces 141 the send history to a single number instead of potentially a series of 142 packet ranges and thereby speeds up ACK verification. 143 144 By default, detecting a gap in the send history is not fatal: only a 145 single warning is generated per connection. The connection can continue 146 to operate even if the ACK verification code is not able to detect some 147 inconsistencies. 148 149 - [OPTIMIZATION] Rearrange the lsquic_send_ctl struct 150 151 The first part of struct lsquic_send_ctl now consists of members that 152 are used in lsquic_send_ctl_got_ack() (in the absense of packet loss, 153 which is the normal case). To speed up reads and writes, we no longer 154 try to save space by using 8- and 16-bit integers. Use regular integer 155 width for everything. 156 157 - [OPTIMIZATION] Cache size of sent packet. 158 159 - [OPTIMIZATION] Keep track of the largest ACKed in packet_out 160 161 Instead of parsing our own ACK frames when packet has been acked, 162 use the value saved in the packet_out structure when the ACK frame 163 was generated. 164 165 - [OPTIMIZATION] Take RTT sampling conditional out of ACK loop 166 167 - [OPTIMIZATION] ACK processing: only call clock_gettime() if needed 168 169 - [OPTIMIZATION] Several code-level optimizations to ACK processing. 170 171 - Fix: http_client: fix -I flag; switch assert() to abort() 172 1732018-02-26 174 - [API Change] lsquic_engine_connect() returns pointer to the connection 175 object. 176 - [API Change] Add lsquic_conn_get_engine() to get engine object from 177 connection object. 178 - [API Change] Add lsquic_conn_status() to query connection status. 179 - [API Change] Add add lsquic_conn_set_ctx(). 180 - [API Change] Add new timestamp format, e.g. 2017-03-21 13:43:46.671345 181 - [OPTIMIZATION] Process handshake STREAM frames as soon as packet 182 arrives. 183 - [OPTIMIZATION] Do not compile expensive send controller sanity check 184 by default. 185 - [OPTIMIZATION] Add fast path to gquic_be_gen_reg_pkt_header. 186 - [OPTIMIZATION] Only make squeeze function call if necessary. 187 - [OPTIMIZATION] Speed up Q039 ACK frame parsing. 188 - [OPTIMIZATION] Fit most used elements of packet_out into first 64 bytes. 189 - [OPTIMIZATION] Keep track of scheduled bytes instead of calculating. 190 - [OPTIMIZATION] Prefetch next unacked packet when processing ACK. 191 - [OPTIMIZATION] Leverage fact that ACK ranges and unacked list are. 192 ordered. 193 - [OPTIMIZATION] Reduce function pointer use for STREAM frame generation 194 - Fix: reset incoming streams that arrive after we send GOAWAY. 195 - Fix: delay client on_new_conn() call until connection is fully set up. 196 - Fixes to buffered packets logic: splitting, STREAM frame elision. 197 - Fix: do not dispatch on_write callback if no packets are available. 198 - Fix WINDOW_UPDATE send and resend logic. 199 - Fix STREAM frame extension code. 200 - Fix: Drop unflushed data when stream is reset. 201 - Switch to tracking CWND using bytes rather than packets. 202 - Fix TCP friendly adjustment in cubic. 203 - Fix: do not generate invalid STOP_WAITING frames during high packet 204 loss. 205 - Pacer fixes. 206 2072017-12-18 208 209 - Fix: better follow cubic curve after idle period 210 - Fix: add missing parts to outgoing packet splitting code 211 - Fix: compilation using gcc 4.8.4 212 2132017-10-31 214 215 - Add APIs.txt -- describes LSQUIC APIs 216 2172017-10-31 218 219 - [API Change] Sendfile-like functionality is gone. The stream no 220 longer opens files and deals with file descriptors. (Among other 221 things, this makes the code more portable.) Three writing functions 222 are provided: 223 224 lsquic_stream_write 225 lsquic_stream_writev 226 lsquic_stream_writef (NEW) 227 228 lsquic_stream_writef() is given an abstract reader that has function 229 pointers for size() and read() functions which the user can implement. 230 This is the most flexible way. lsquic_stream_write() and 231 lsquic_stream_writev() are now both implemented as wrappers around 232 lsquic_stream_writef(). 233 234 - [OPTIMIZATION] When writing to stream, be it within or without the 235 on_write() callback, place data directly into packet buffer, 236 bypassing auxiliary data structures. This reduces amount of memory 237 required, for the amount of data that can be written is limited 238 by the congestion window. 239 240 To support writes outside the on_write() callback, we keep N 241 outgoing packet buffers per connection which can be written to 242 by any stream. One half of these are reserved for the highest 243 priority stream(s), the other half for all other streams. This way, 244 low-priority streams cannot write instead of high-priority streams 245 and, on the other hand, low-priority streams get a chance to send 246 their packets out. 247 248 The algorithm is as follows: 249 250 - When user writes to stream outside of the callback: 251 - If this is the highest priority stream, place it onto the 252 reserved N/2 queue or fail. 253 (The actual size of this queue is dynamic -- MAX(N/2, CWND) -- 254 rather than N/2, allowing high-priority streams to write as 255 much as can be sent.) 256 - If the stream is not the highest priority, try to place the 257 data onto the reserved N/2 queue or fail. 258 - When tick occurs *and* more packets can be scheduled: 259 - Transfer packets from the high N/2 queue to the scheduled 260 queue. 261 - If more scheduling is allowed: 262 - Call on_write callbacks for highest-priority streams, 263 placing resulting packets directly onto the scheduled queue. 264 - If more scheduling is allowed: 265 - Transfer packets from the low N/2 queue to the scheduled 266 queue. 267 - If more scheduling is allowed: 268 - Call on_write callbacks for non-highest-priority streams, 269 placing resulting packets directly onto the scheduled queue 270 271 The number N is currently 20, but it could be varied based on 272 resource usage. 273 274 - If stream is created due to incoming headers, make headers readable 275 from on_new. 276 277 - Outgoing packets are no longer marked non-writeable to prevent placing 278 more than one STREAM frame from the same stream into a single packet. 279 This property is maintained via code flow and an explicit check. 280 Packets for stream data are allocated using a special function. 281 282 - STREAM frame elision is cheaper, as we only perform it if a reset 283 stream has outgoing packets referencing it. 284 285 - lsquic_packet_out_t is smaller, as stream_rec elements are now 286 inside a union. 287 2882017-10-12 289 290 - Do not send RST_STREAM when stream is closed for reading 291 - Raise maximum header size from 4K to 64K 292 - Check header name and value lengths against maximum imposed by HPACK 293 - Fix NULL dereference in stream flow controller 294 2952017-10-09 296 297 - Hide handshake implementation behind a set of function pointers 298 - Use monotonically increasing clock 299 - Make sure that retx delay is not larger than the max of 60 seconds 300 3012017-09-29 302 303 - A few fixes to code and README 304 3052017-09-28 306 307 - Add support for Q041; drop support for Q040 308 3092017-09-27 310 311 - Fix CMakeLists.txt: BoringSSL include and lib was mixed up 312 3132017-09-26 314 315 - Add support for Mac OS 316 - Add support for Raspberry Pi 317 - Fix BoringSSL compilation: include <openssl/hmac.h> explicitly 318 3192017-09-22 320 321 - Initial release 322