CHANGELOG revision 97028223
12018-05-09 2 3 - [FEATURE] Add support for Q043. 4 - Support for versions Q037, Q038, Q041, and Q042 has been removed. 5 - Fix typo in debug message. 6 - Fix code indentation. 7 - Add /* fallthru */ comment to stop newer gcc from complaining. 8 - Logger: fix compilation of optimized Windows build. 9 102018-05-04 11 12 - [FEATURE] Add support for Q042. 13 - Remove comment: MSPC is obsolete (no code changes) 14 - Prog: use lsquic_str2ver() when processing -o version flag 15 - Remove unused CTIM and SRBF transport parameters 16 - Disable QUIC versions Q037 and Q038 by default 17 - Fix Windows compilation by including compat header file in 18 lshpack.c 19 - Address warnings produced by newer versions of gcc 20 - Future-proof: turn off -Werror 21 222018-05-02 23 24 - [BUGFIX] Make lsquic_conn_quic_version() available 25 - Switch to using ls-hpack 1.1 26 - [BUGFIX] Do not ignore stream resets after receiving FIN 27 282018-04-27 29 30 - HPACK: do not allow header block to end with table size update. 31 322018-04-25 33 34 - [BUGFIX] Do not create gap in sent packnos when squeezing delayed 35 packets. 36 - [BUGFIX] sendctl checks for all unacked bytes, not just retx bytes. 37 - [BUGFIX] connections with blocked scheduled packets are not tickable 38 for sending. 39 - [BUGFIX] Conn is tickable if it wants to send a connection-level 40 frame. 41 422018-04-23 43 44 - Fix busy loop: tickable must make progress. When connection is 45 self-reporting as tickable, it must make progress when ticked. There 46 are two issues: 47 1. If there are buffered packets, the connection is only tickable if 48 they can be sent out. 49 2. A connection is tickable if there are streams on the servicing 50 queue. When the tick occurs, we must service the stream 51 independent of whether any packets are sent. 52 - Fix assertion in pacer which can be incorrect under some 53 conditions. 54 - cmake: do not turn on address sanitizer if in Travis. 55 562018-04-20 57 58 - [BUGFIX] Fix bug in lsquic_engine_connect() exposed by yesterday's 59 changes. 60 612018-04-19 62 63 - [BUGFIX] Add connection to Tickable Queue on stream write 64 - cmake: use MSVC variable instead of trying to detect 65 - engine: improve connection incref/decref logging 66 - stream: don't ignore errors that may occur on triggered flush 67 - connection: remove obsolete method 68 - engine: indicate connection as tickable if previous call went 69 over threshold 70 712018-04-09 72 73 [API Change, OPTIMIZATION] Only process conns that need to be processed 74 75 The API is simplified: do not expose the user code to several 76 queues. A "connection queue" is now an internal concept. 77 The user processes connections using the single function 78 lsquic_engine_process_conns(). When this function is called, 79 only those connections are processed that need to be processed. 80 A connection needs to be processed when: 81 82 1. New incoming packets have been fed to the connection. 83 2. User wants to read from a stream that is readable. 84 3. User wants to write to a stream that is writeable. 85 4. There are buffered packets that can be sent out. (This 86 means that the user wrote to a stream outside of the 87 lsquic library callback.) 88 5. A control frame (such as BLOCKED) needs to be sent out. 89 6. A stream needs to be serviced or delayed stream needs to 90 be created. 91 7. An alarm rings. 92 8. Pacer timer expires. 93 94 To achieve this, the library places the connections into two 95 priority queues (min heaps): 96 97 1. Tickable Queue; and 98 2. Advisory Tick Time queue (ATTQ). 99 100 Each time lsquic_engine_process_conns() is called, the Tickable 101 Queue is emptied. After the connections have been ticked, they are 102 queried again: if a connection is not being closed, it is placed 103 either in the Tickable Queue if it is ready to be ticked again or 104 it is placed in the Advisory Tick Time Queue. It is assumed that 105 a connection always has at least one timer set (the idle alarm). 106 107 The connections in the Tickable Queue are arranged in the least 108 recently ticked order. This lets connections that have been quiet 109 longer to get their packets scheduled first. 110 111 This change means that the library no longer needs to be ticked 112 periodically. The user code can query the library when is the 113 next tick event and schedule it exactly. When connections are 114 processed, only the tickable connections are processed, not *all* 115 the connections. When there are no tick events, it means that no 116 timer event is necessary -- only the file descriptor READ event 117 is active. 118 119 The following are improvements and simplifications that have 120 been triggered: 121 122 - Queue of connections with incoming packets is gone. 123 - "Pending Read/Write Events" Queue is gone (along with its 124 history and progress checks). This queue has become the 125 Tickable Queue. 126 - The connection hash no longer needs to track the connection 127 insertion order. 128 1292018-04-02 130 131 - [FEATURE] Windows support 132 133 - Reduce stack use -- outgoing packet batch is now allocated on the heap. 134 1352018-03-09 136 137 - [OPTIMIZATION] Merge series of ACKs if possible 138 139 Parsed single-range ACK frames (that is the majority of frames) are 140 saved in the connection and their processing is deferred until the 141 connection is ticked. If several ACKs come in a series between 142 adjacent ticks, we check whether the latest ACK is a strict superset 143 of the saved ACK. If it is, the older ACK is not processed. 144 145 If ACK frames can be merged, they are merged and only one of them is 146 either processed or saved. 147 148 - [OPTIMIZATION] Speed up ACK verification by simplifying send history. 149 150 Never generate a gap in the sent packet number sequence. This reduces 151 the send history to a single number instead of potentially a series of 152 packet ranges and thereby speeds up ACK verification. 153 154 By default, detecting a gap in the send history is not fatal: only a 155 single warning is generated per connection. The connection can continue 156 to operate even if the ACK verification code is not able to detect some 157 inconsistencies. 158 159 - [OPTIMIZATION] Rearrange the lsquic_send_ctl struct 160 161 The first part of struct lsquic_send_ctl now consists of members that 162 are used in lsquic_send_ctl_got_ack() (in the absense of packet loss, 163 which is the normal case). To speed up reads and writes, we no longer 164 try to save space by using 8- and 16-bit integers. Use regular integer 165 width for everything. 166 167 - [OPTIMIZATION] Cache size of sent packet. 168 169 - [OPTIMIZATION] Keep track of the largest ACKed in packet_out 170 171 Instead of parsing our own ACK frames when packet has been acked, 172 use the value saved in the packet_out structure when the ACK frame 173 was generated. 174 175 - [OPTIMIZATION] Take RTT sampling conditional out of ACK loop 176 177 - [OPTIMIZATION] ACK processing: only call clock_gettime() if needed 178 179 - [OPTIMIZATION] Several code-level optimizations to ACK processing. 180 181 - Fix: http_client: fix -I flag; switch assert() to abort() 182 1832018-02-26 184 - [API Change] lsquic_engine_connect() returns pointer to the connection 185 object. 186 - [API Change] Add lsquic_conn_get_engine() to get engine object from 187 connection object. 188 - [API Change] Add lsquic_conn_status() to query connection status. 189 - [API Change] Add add lsquic_conn_set_ctx(). 190 - [API Change] Add new timestamp format, e.g. 2017-03-21 13:43:46.671345 191 - [OPTIMIZATION] Process handshake STREAM frames as soon as packet 192 arrives. 193 - [OPTIMIZATION] Do not compile expensive send controller sanity check 194 by default. 195 - [OPTIMIZATION] Add fast path to gquic_be_gen_reg_pkt_header. 196 - [OPTIMIZATION] Only make squeeze function call if necessary. 197 - [OPTIMIZATION] Speed up Q039 ACK frame parsing. 198 - [OPTIMIZATION] Fit most used elements of packet_out into first 64 bytes. 199 - [OPTIMIZATION] Keep track of scheduled bytes instead of calculating. 200 - [OPTIMIZATION] Prefetch next unacked packet when processing ACK. 201 - [OPTIMIZATION] Leverage fact that ACK ranges and unacked list are. 202 ordered. 203 - [OPTIMIZATION] Reduce function pointer use for STREAM frame generation 204 - Fix: reset incoming streams that arrive after we send GOAWAY. 205 - Fix: delay client on_new_conn() call until connection is fully set up. 206 - Fixes to buffered packets logic: splitting, STREAM frame elision. 207 - Fix: do not dispatch on_write callback if no packets are available. 208 - Fix WINDOW_UPDATE send and resend logic. 209 - Fix STREAM frame extension code. 210 - Fix: Drop unflushed data when stream is reset. 211 - Switch to tracking CWND using bytes rather than packets. 212 - Fix TCP friendly adjustment in cubic. 213 - Fix: do not generate invalid STOP_WAITING frames during high packet 214 loss. 215 - Pacer fixes. 216 2172017-12-18 218 219 - Fix: better follow cubic curve after idle period 220 - Fix: add missing parts to outgoing packet splitting code 221 - Fix: compilation using gcc 4.8.4 222 2232017-10-31 224 225 - Add APIs.txt -- describes LSQUIC APIs 226 2272017-10-31 228 229 - [API Change] Sendfile-like functionality is gone. The stream no 230 longer opens files and deals with file descriptors. (Among other 231 things, this makes the code more portable.) Three writing functions 232 are provided: 233 234 lsquic_stream_write 235 lsquic_stream_writev 236 lsquic_stream_writef (NEW) 237 238 lsquic_stream_writef() is given an abstract reader that has function 239 pointers for size() and read() functions which the user can implement. 240 This is the most flexible way. lsquic_stream_write() and 241 lsquic_stream_writev() are now both implemented as wrappers around 242 lsquic_stream_writef(). 243 244 - [OPTIMIZATION] When writing to stream, be it within or without the 245 on_write() callback, place data directly into packet buffer, 246 bypassing auxiliary data structures. This reduces amount of memory 247 required, for the amount of data that can be written is limited 248 by the congestion window. 249 250 To support writes outside the on_write() callback, we keep N 251 outgoing packet buffers per connection which can be written to 252 by any stream. One half of these are reserved for the highest 253 priority stream(s), the other half for all other streams. This way, 254 low-priority streams cannot write instead of high-priority streams 255 and, on the other hand, low-priority streams get a chance to send 256 their packets out. 257 258 The algorithm is as follows: 259 260 - When user writes to stream outside of the callback: 261 - If this is the highest priority stream, place it onto the 262 reserved N/2 queue or fail. 263 (The actual size of this queue is dynamic -- MAX(N/2, CWND) -- 264 rather than N/2, allowing high-priority streams to write as 265 much as can be sent.) 266 - If the stream is not the highest priority, try to place the 267 data onto the reserved N/2 queue or fail. 268 - When tick occurs *and* more packets can be scheduled: 269 - Transfer packets from the high N/2 queue to the scheduled 270 queue. 271 - If more scheduling is allowed: 272 - Call on_write callbacks for highest-priority streams, 273 placing resulting packets directly onto the scheduled queue. 274 - If more scheduling is allowed: 275 - Transfer packets from the low N/2 queue to the scheduled 276 queue. 277 - If more scheduling is allowed: 278 - Call on_write callbacks for non-highest-priority streams, 279 placing resulting packets directly onto the scheduled queue 280 281 The number N is currently 20, but it could be varied based on 282 resource usage. 283 284 - If stream is created due to incoming headers, make headers readable 285 from on_new. 286 287 - Outgoing packets are no longer marked non-writeable to prevent placing 288 more than one STREAM frame from the same stream into a single packet. 289 This property is maintained via code flow and an explicit check. 290 Packets for stream data are allocated using a special function. 291 292 - STREAM frame elision is cheaper, as we only perform it if a reset 293 stream has outgoing packets referencing it. 294 295 - lsquic_packet_out_t is smaller, as stream_rec elements are now 296 inside a union. 297 2982017-10-12 299 300 - Do not send RST_STREAM when stream is closed for reading 301 - Raise maximum header size from 4K to 64K 302 - Check header name and value lengths against maximum imposed by HPACK 303 - Fix NULL dereference in stream flow controller 304 3052017-10-09 306 307 - Hide handshake implementation behind a set of function pointers 308 - Use monotonically increasing clock 309 - Make sure that retx delay is not larger than the max of 60 seconds 310 3112017-09-29 312 313 - A few fixes to code and README 314 3152017-09-28 316 317 - Add support for Q041; drop support for Q040 318 3192017-09-27 320 321 - Fix CMakeLists.txt: BoringSSL include and lib was mixed up 322 3232017-09-26 324 325 - Add support for Mac OS 326 - Add support for Raspberry Pi 327 - Fix BoringSSL compilation: include <openssl/hmac.h> explicitly 328 3292017-09-22 330 331 - Initial release 332