History log of /lsquic/src/liblsquic/lsquic_handshake.c
Revision Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
# a74702c6 06-May-2022 George Wang <gwang@litespeedtech.com>

Release 3.1.0

# e237d779 28-Apr-2022 George Wang <gwang@litespeedtech.com>

Release 3.0.5

# ed94ac12 15-Jun-2021 wangfuyu <wangfuyu1989@foxmail.com>

m) do not try to delete stk from shi_ctx (#295)

stk never be inserted to shi_ctx, so we don't need try to delete it.

Co-authored-by: wangfuyu <ivanfywang@gmail.com>

# 293df8d6 12-Apr-2021 George Wang <gwang@litespeedtech.com>

Release 2.30.0

- [FEATURE] Added support for sending/receiving multiple headers to address the
case related to "100 continue" header handling.
- [BUGFIX] Addressed high CPU usage for a GOAWAY connection before sending
CONNECTION_CLOSE.
- [BUGFIX] Addressed SIGFPE due to zero pacing rate. (ISSUE #254).
- [BUGFIX] Fixed a minor issue related to multi-paths.

# ab69788e 02-Apr-2021 wangfuyu <wangfuyu1989@foxmail.com>

Fix: must take xlct into account while determine_rtt (#248)

Co-authored-by: ivanfywang <ivanfywang@gmail.com>

# f3690fdc 30-Mar-2021 wangfuyu <wangfuyu1989@foxmail.com>

Compatible with 16+ Bytes scid (#244)

Co-authored-by: ivanfywang <wentaomao@tencent.com>

# f1d5a1a4 23-Feb-2021 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.29.2

- Fix regression in gQUIC server: bug #234.

# 26e8f082 10-Feb-2021 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.29.0

- [FEATURE] QUIC and HTTP/3 Internet Draft 34 support and v1 support.
The latter is turned off by default.
- Drop support for ID-28 and ID-32.
- [BUGFIX] IETF QUIC mini conn receive history (trechist): allow
unlimited inserts by dropping smallest elements.
- [BUGFIX] gQUIC: set STTL to correct value, issue #226.
- [BUGFIX] Account for poison packet gap when MTU probe was too large.

# 38e83598 12-Jan-2021 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

API: add lsquic_conn_get_sni(), fixes issue #203

# 06b2a236 06-Jan-2021 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.27.1

- [API] New knob to set outgoing packet batch size.
- Aborted connection now become tickable immediately.
- Abort connection when HTTP/3 frame cannot be opened (can only happen
when malloc fails).

# 464a1af9 07-Oct-2020 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Fix Windows build

# fbc6cc04 07-Oct-2020 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.22.0

- [FEATURE] Extensible HTTP Priorities (HTTP/3 only).
- [FEATURE] Add conn context to packet-out memory interface (PR #175).
- [BUGFIX] gQUIC proof generation: allocate buffer big enough for
signature (issue #173).
- [BUGFIX] Make library thread-safe: drop use of global variables
(issue #133, issue #167).
- [BUGFIX] Deactivate only *recent* HQ frame, not any HQ frame.
- [BUGFIX] gQUIC server: associate compressed cert with SSL_CTX,
instead of keeping them in a separate hash, potentially leading
to mismatches.
- [BUGFIX] Stream data discard infinite loop: break on FIN.
- cmake: add install target via -DCMAKE_INSTALL_PREFIX (PR #171).
- Support randomized packet number to begin a connection.
- Mini and full IETF connection size optimization.
- http_client: specify HTTP priorities based on stream conditions.

# fecdd104 03-Oct-2020 Victor Stewart <v@nametag.social>

GSO-Friendly Packet Memory (#175)

# 2f4629f2 01-Oct-2020 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Fix several thread safety issues

Fixes bug #128 and bug #167.

# b1a7c3f9 16-Sep-2020 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.20.0

- [FEATURE] QUIC and HTTP/3 Internet Draft 30 support.
- [FEATURE] Unreliable Datagram Extension support.
- [FEATURE] Adaptive congestion controller.
- [BUGFIX] Do not send MAX_STREAM_DATA frames on crypto streams.
- [BUGFIX] Fail with CRYPTO_BUFFER_EXCEEDED when too much CRYPTO
data comes in.
- [BUFFIX] Spin bit is now strictly per path; value is reset on
DCID change.
- [BUGFIX] Check that max value of max_streams_uni and
max_streams_bidi TPs is 2^60.
- [BUGFIX] Close IETF mini conn immediately if crypto session
cannot be initialized.
- Deprecate ID-28 (no browser uses it): it's no longer in the
default versions list.
- New programs duck_server and duck_client that implement the
experimental siduck-00 protocol. They quack!
- IETF crypto streams: don't limit ourselves from sending.
- Command-line programs: turn off QL loss bits if -G is used, as
Wireshark cannot decrypt QUIC packets when this extension is used.
- Turn all h3 framing unit tests back on.
- Fix malo initialization when compiled in no-pool mode.

# 49f1f4f6 02-Sep-2020 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.19.8

- [FEATURE] Update the timestamp extension to latest version.
- [FEATURE] Cope with appearance of ECN blackholes.
- [OPTIMIZATION] return packno offset and size when header is generated.
- [BUGFIX] ignore old ACK frames in mini conns.
- [BUGFIX] Mark initial server path as initialized.
- [BUGFIX] Do not merge ACK if ECN counts do not match.
- Turn incoming packet number history in mini conn back on.
- Record mini conn event history again when compiled in debug mode.
- IETF mini conn: log when ACK is queued.
- Clean up and refactor code in several places.

# 7483dee0 07-Jul-2020 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.18.0

- [API] Rename "0-RTT" to "session resumption." In IETF QUIC, "0-RTT"
always refers to early data, meaning a request that the server can
reply to in the very first return flight. A more appropriate name
for what we support on the client site is "session resumption," which
is standard TLS terminology. Later, when we add support for 0-RTT
(early data), we can use the 0-RTT terminology again, this time in
proper context.
- [BUGFIX] Do not set certificate callback if ea_lookup_cert is NULL.
- [BUGFIX] Make connection tickable when it's marked as closed.
- [BUGFIX] Fail certificate lookup if SNI is not present in HTTP mode.
- Several documentation fixes and improvements.
- Minor code cleanup.

# fb3e20e0 03-Jun-2020 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Fix Windows support

# 77a28812 07-Apr-2020 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.14.1

- [BUGFIX] Place connections on tickable queue when sending is reenabled.
- [BUGFIX] A connection is tickable if it has unsent packets.
- [BUGFIX] Heed peer's max_packet_size transport parameter.

# a5fa05f9 12-Mar-2020 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.13.0

- [API] Use lsxpack_header structure to process incoming headers.
- [BUGFIX] Fix assertion when zero-padding Initial packet.
- [BUGFIX] Use idle timeout before we learn of peer's value.
- Use ls-hpack 2.0.0 -- has lsxpack_header changes.
- Use ls-qpack 0.14.0 -- new, common with ls-hpack, XXH seed (not used yet).
- Code cleanup: prefix exported functions with "lsquic_".

# 10c41073 16-Jan-2020 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.8.9

- [BUGFIX] Use ls-qpack 0.11.1
- [OPTIMIZATION] Generate random bytes in batches.
- Change loss_bits transport parameter ID to 0x1057 following latest
draft.
- Randomize period with which PINGs are sent to elicit ACKs.
- Some refactoring and code cleanup.

# 7d09751d 10-Jan-2020 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.8.7

- [BUGFIX] Initial packet size check for IETF mini conn applies to
UDP payload, not QUIC packet.
- Support old and new school loss_bits transport parameter.
- Use Q run length of 64 as suggested in the loss bits Draft.
- Undo square wave count when packet is delayed.
- Code cleanup; minor fixes.

# 72bbf1fb 07-Jan-2020 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.8.5

- [BUGFIX] Fix unintended sign extension when removing header protection.

# 747be414 06-Jan-2020 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.8.4

- [HTTP3] Verify number of bytes in incoming DATA frames against
content-length.
- [HTTP3] Stop issuing streams credits if peer stops opening QPACK
decoder window. This addresses a potential attack whereby client
can cause the server to keep allocating memory. See Security
Considerations in the QPACK draft.
- [BUGFIX] Mini conn: don't shorten max packet size for Q050 and later.
- [BUGFIX] Init IETF connection flow controller using correct setting.
- Code cleanup and minor fixes.

# de46bf2f 31-Dec-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.8.1

- [FEATURE] Use occasional packet number gaps to detect optimistic
ACK attacks.
- [BUGFIX] Q050 client: all packet numbers are in the App PNS.
- [OPTIMIZATION] Merge multi-range ACK frames, not just single-range
ACK frames.
- IETF QUIC: use RTT estimate in ack timeout calculation.
- IETF handshake: abort conn when unexpected errors occur.
- Use PING rather than MAX_DATA frames to elicit ACKs from peer.
- Server: enforce 1200 byte Initial minimum packet size.
- [CLEANUP] Remove code to disable gQUIC crypto.
- [CLEANUP] Remove n_timestamps from ACK info struct.
- Optimize driver: reuse previous ancillary message when possible.

# 7a8b2ece 24-Dec-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.8.0

- [FEATURE] Add support for Q050.
- [OPTIMIZATION] Reduce mallocs in gQUIC handshake.
- [BUGFIX] Disable redo of failed STREAM frame insertion with debug
logging.

# a137764b 11-Dec-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.7.2

- [BUGFIX] Send controller: update scheduled bytes when DCID length
changes (IETF client).
- [BUGFIX] Drop alarm check from sanity test. It no longer works now
that we use loss chains.
- [PORTABILITY] Fix build on Alpine Linux.
- [PORTABILITY] Fix build using XCode.
- Client initial DCID length: use RAND_bytes() instead of rand(3).
- Add unit tests for connection min heap.
- [DEBUG] Log CID in gQUIC handshake module
- [DEBUG] Turn on extra checks for IETF client send controller.
- [DEBUG] Dedup next advisory tick messages when reason is IDLE timer.
- [DEBUG] QPACK decoder handler: log header error code.

# 2f7aa658 13-Nov-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.6.3

- [BUGFIX] Close DATA frames with empty payload correctly.

# a0e1aeee 31-Oct-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.5.0

- [API] lsquic_engine_connect() can now be passed QUIC version to use.
- [OPTIMIZATION] Queue opportunistic ACKs if there is data to be sent.
- [BUGFIX] Don't evict streams from priority iterator if there is
only one queue.
- [OPTIMIZATION, BUGFIX] Several other optimizations and bug fixes.
- Use ls-qpack v0.10.7.

# 34e9ac5f 24-Oct-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.4.10: fix regression in 2.4.9, use ls-qpack 0.10.6

# df992bce 24-Oct-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 2.4.9

- [BUGFIX] IETF QUIC server: fix uninitialized variable use.
- [BUGFIX] make sure TLSv1.3 is not disabled in SSL object.
- [BUGFIX] Use issuer name and serial number to cache certs (SKID
values are not unique).
- [BUGFIX] Always set the idle alarm in IETF connection so that it
can time out.

# 5392f7a3 11-Sep-2019 LiteSpeed Tech <info@litespeedtech.com>

Release 2.2.0: server included, ID-22 supported (#76)

# 55cd0b38 12-Apr-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 1.21.0

[FEATURE] Add qlog log module.

# c7d81ce1 01-Apr-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 1.20.0

[FEATURE] Add support for Q046.

# 03d03a42 06-Mar-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Add useless variable initialization for Windows

# 8437e4a4 06-Mar-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 1.19.5

- [BUGFIX] Use correct public key from PUBS based on KEXS index.
- [BUGFIX] Check flags before dispatching writes, avoiding assert.
- [BUGFIX] Set :scheme to "https" (instead of "HTTP").

# 90fe3b25 25-Feb-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 1.19.4

- [BUGFIX] Check buffer bounds when looking up version in 0-RTT blob.
- [BUGFIX] http_client: don't fetch 0-rtt info if handshake failed.
- Log number of pacer calls at DEBUG, rather than NOTICE, level.

# 9c444524 18-Feb-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 1.19.3

- [BUGFIX] Q044: don't encode packet number in 6 bytes. Six-byte
packet number encoding does not exist in Q044. This fixes a
regression introduced in '[BUGFIX] Buffered packets can contain
ACK frames' -- we need to keep QUIC version in mind when selecting
the longest possible packet number encoding used for the buffered
packet that carries the ACK.
- [BUGFIX] Do not increase CWND when timeout occurs.
- http_client: support setting handshake timeout on command line.
Use -o handshake_to=timeout.
- http_client: use -k to connect UDP socket to pick up ICMP errors.
- http_client: allow pathless mode, when only handshake is performed
without issuing any requests. This can be done by simply not
specifying a -p flag on the command line.

# 33291708 11-Feb-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 1.19.2

- [BUGFIX] Begin negotiation with version provided in 0-RTT info.
- [BUGFIX] Version checking in zero_rtt deserialize function.

# 2b051cfe 05-Feb-2019 Stephen Petrides <sdpetrides@gmail.com>

[BUILDFIX] Replace empty arrays in zero_rtt structs with local var ptrs (#66)

# 8ca33e0e 04-Feb-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 1.19.0

- [FEATURE, API Change] 0-RTT support. Add function to export 0-RTT
information; it can be supplied to a subsequent connect() call.
- [FEATURE] Add -0 flag to http_client to exercise 0-RTT support.
- [BUGFIX] Resuscitate the Windows build.
- [BUGFIX] Send HTTP settings (max header list size) if necessary.
- [BUGFIX] Buffered packets can contain ACK frames.
- [BUGFIX] Make packet writeable once all STREAM frames are elided.
- [BUGFIX] Fix potential null dereference when realloc fails.
- cmake: simplify build configuration.

# 229fce07 04-Jan-2019 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 1.17.11

Fix strict aliasing warning in when compiling with optimizations

# bf2c7037 17-Nov-2018 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 1.17.3

[BUGFIX] Do not send STOP_WAITING frames when using Q044

# 1e75f938 16-Oct-2018 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Release 1.17.0

- [API Change] Packet out Memory Interface (PMI) update:
- Split PMI pool return into pmi_release and pmi_return
- PMI callbacks take peer_ctx and is_ipv6 arguments
- [BUGFIX] Fix use-after-free when certificate is updated
- Silence gcc warning in optimized mode by performing useless
initialization
- cmake: use the standard variable CMAKE_BUILD_TYPE instead of
DEVEL_MODE

# 7f2bd84c 17-Aug-2018 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

1.12.0: [FEATURE, API Change] Certificate verification

# 9626cfc2 16-Aug-2018 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

1.11.0: [FEATURE] Add support for Q044

# 96f77e20 30-May-2018 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

[FEATURE, API CHANGE] Support zero-sized CIDs in received packets

# 052a1c28 10-May-2018 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Drop support for versions Q037, Q038, and Q042

# 2a5cd80e 08-May-2018 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Fix indentation: this is a better way to address new gcc warnings

# 4b332c36 04-May-2018 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Latest changes

- Remove comment: MSPC is obsolete (no code changes)
- Prog: use lsquic_str2ver() when processing -o version flag
- Remove unused CTIM and SRBF transport parameters
- Disable QUIC versions Q037 and Q038 by default
- Fix Windows compilation by including compat header file in lshpack.c
- Address warnings produced by newer versions of gcc
- Future-proof: turn off -Werror

# 10c492f0 03-Apr-2018 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Update copyright year; add CONTRIBUTORS.txt

# b93f59be 30-Mar-2018 Bob Perper <rperper@litespeedtech.com>

Initial PlusWindows commit

# 461e84d8 13-Mar-2018 Amol Deshpande <amol.deshpande@outlook.com>

compiles in debug/release. tests pass (in debug config at least)

# bfc7bfd8 27-Feb-2018 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Latest changes

- [API Change] lsquic_engine_connect() returns pointer to the connection
object.
- [API Change] Add lsquic_conn_get_engine() to get engine object from
connection object.
- [API Change] Add lsquic_conn_status() to query connection status.
- [API Change] Add add lsquic_conn_set_ctx().
- [API Change] Add new timestamp format, e.g. 2017-03-21 13:43:46.671345
- [OPTIMIZATION] Process handshake STREAM frames as soon as packet
arrives.
- [OPTIMIZATION] Do not compile expensive send controller sanity check
by default.
- [OPTIMIZATION] Add fast path to gquic_be_gen_reg_pkt_header.
- [OPTIMIZATION] Only make squeeze function call if necessary.
- [OPTIMIZATION] Speed up Q039 ACK frame parsing.
- [OPTIMIZATION] Fit most used elements of packet_out into first 64 bytes.
- [OPTIMIZATION] Keep track of scheduled bytes instead of calculating.
- [OPTIMIZATION] Prefetch next unacked packet when processing ACK.
- [OPTIMIZATION] Leverage fact that ACK ranges and unacked list are.
ordered.
- [OPTIMIZATION] Reduce function pointer use for STREAM frame generation
- Fix: reset incoming streams that arrive after we send GOAWAY.
- Fix: delay client on_new_conn() call until connection is fully set up.
- Fixes to buffered packets logic: splitting, STREAM frame elision.
- Fix: do not dispatch on_write callback if no packets are available.
- Fix WINDOW_UPDATE send and resend logic.
- Fix STREAM frame extension code.
- Fix: Drop unflushed data when stream is reset.
- Switch to tracking CWND using bytes rather than packets.
- Fix TCP friendly adjustment in cubic.
- Fix: do not generate invalid STOP_WAITING frames during high packet
loss.
- Pacer fixes.

# c51ce338 31-Oct-2017 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Latest changes

- [API Change] Sendfile-like functionality is gone. The stream no
longer opens files and deals with file descriptors. (Among other
things, this makes the code more portable.) Three writing functions
are provided:

lsquic_stream_write
lsquic_stream_writev
lsquic_stream_writef (NEW)

lsquic_stream_writef() is given an abstract reader that has function
pointers for size() and read() functions which the user can implement.
This is the most flexible way. lsquic_stream_write() and
lsquic_stream_writev() are now both implemented as wrappers around
lsquic_stream_writef().

- [OPTIMIZATION] When writing to stream, be it within or without the
on_write() callback, place data directly into packet buffer,
bypassing auxiliary data structures. This reduces amount of memory
required, for the amount of data that can be written is limited
by the congestion window.

To support writes outside the on_write() callback, we keep N
outgoing packet buffers per connection which can be written to
by any stream. One half of these are reserved for the highest
priority stream(s), the other half for all other streams. This way,
low-priority streams cannot write instead of high-priority streams
and, on the other hand, low-priority streams get a chance to send
their packets out.

The algorithm is as follows:

- When user writes to stream outside of the callback:
- If this is the highest priority stream, place it onto the
reserved N/2 queue or fail.
(The actual size of this queue is dynamic -- MAX(N/2, CWND) --
rather than N/2, allowing high-priority streams to write as
much as can be sent.)
- If the stream is not the highest priority, try to place the
data onto the reserved N/2 queue or fail.
- When tick occurs *and* more packets can be scheduled:
- Transfer packets from the high N/2 queue to the scheduled
queue.
- If more scheduling is allowed:
- Call on_write callbacks for highest-priority streams,
placing resulting packets directly onto the scheduled queue.
- If more scheduling is allowed:
- Transfer packets from the low N/2 queue to the scheduled
queue.
- If more scheduling is allowed:
- Call on_write callbacks for non-highest-priority streams,
placing resulting packets directly onto the scheduled queue

The number N is currently 20, but it could be varied based on
resource usage.

- If stream is created due to incoming headers, make headers readable
from on_new.

- Outgoing packets are no longer marked non-writeable to prevent placing
more than one STREAM frame from the same stream into a single packet.
This property is maintained via code flow and an explicit check.
Packets for stream data are allocated using a special function.

- STREAM frame elision is cheaper, as we only perform it if a reset
stream has outgoing packets referencing it.

- lsquic_packet_out_t is smaller, as stream_rec elements are now
inside a union.

# 83287402 09-Oct-2017 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

Latest changes

- Hide handshake implementation behind a set of function pointers
- Use monotonically increasing clock
- Make sure that retx delay is not larger than the max of 60 seconds

# 50aadb33 23-Sep-2017 Dmitri Tikhonov <dtikhonov@litespeedtech.com>

LSQUIC Client: Initial release